Skip to content

Conversation

@akowalska622
Copy link
Contributor

@akowalska622 akowalska622 commented Nov 18, 2025

Summary

Resolves #239420

This pull request refactors the "tabs bar menu" feature in the Unified Tabs component by renaming it to "tabs menu" throughout the codebase and updating all relevant references, props, and test IDs. The changes are focused on improving clarity and consistency in naming, without altering functionality.

Eventually only the tooltip copy was changed within the PR. No code references were changed.

No functional behavior was changed - this is a pure renaming and refactoring for clarity and maintainability.

Screenshot 2025-11-18 at 11 09 36

Documentation adjusted in: Rename "Tabs bar menu" to "Tabs menu"

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@akowalska622 akowalska622 self-assigned this Nov 18, 2025
@akowalska622 akowalska622 added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// backport:version Backport to applied version labels v9.2.0 Feature:DiscoverTabs Tabs feature within Discover labels Nov 18, 2025
@akowalska622 akowalska622 marked this pull request as ready for review November 18, 2025 11:56
@akowalska622 akowalska622 requested a review from a team as a code owner November 18, 2025 11:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 20, 2025

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #60 / discover/tabs tabs sharing can share an unsaved tab
  • [job] [logs] FTR Configs #60 / discover/tabs tabs sharing can share an unsaved tab
  • [job] [logs] FTR Configs #51 / Fleet packages test Automatic agent upgrades "after all" hook for "should retry upgrading agents stuck in updating"
  • [job] [logs] FTR Configs #51 / Fleet packages test Automatic agent upgrades should take agents marked and ready for retry into account and upgrade them

History

cc @akowalska622

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@akowalska622 akowalska622 merged commit c620d11 into elastic:main Nov 21, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.2

https://github.com/elastic/kibana/actions/runs/19578049409

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

akowalska622 added a commit to elastic/docs-content that referenced this pull request Nov 24, 2025
Related to [[Discover] Rename "Tabs bar menu" to "Tabs
menu"](elastic/kibana#239420 (comment))

This pull request makes a minor update to the documentation for tab
management in Discover.
It reflects changes from [[Discover][Unified Tabs] Rename "Tabs bar
menu" to "Tabs menu"](elastic/kibana#243332 (comment))
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 24, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @akowalska622

kibanamachine added a commit that referenced this pull request Nov 25, 2025
…243332) (#243879)

# Backport

This will backport the following commits from `main` to `9.2`:
- [[Discover][Unified Tabs] Rename "Tabs bar menu" to "Tabs menu"
(#243332)](#243332)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ania
Kowalska","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-11-21T17:13:53Z","message":"[Discover][Unified
Tabs] Rename \"Tabs bar menu\" to \"Tabs menu\"
(#243332)","sha":"c620d1103cc6a1d56e192e6c8b54990327607aab","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","Team:DataDiscovery","backport:version","v9.2.0","v9.3.0","Feature:DiscoverTabs"],"title":"[Discover][Unified
Tabs] Rename \"Tabs bar menu\" to \"Tabs
menu\"","number":243332,"url":"https://github.com/elastic/kibana/pull/243332","mergeCommit":{"message":"[Discover][Unified
Tabs] Rename \"Tabs bar menu\" to \"Tabs menu\"
(#243332)","sha":"c620d1103cc6a1d56e192e6c8b54990327607aab"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/243332","number":243332,"mergeCommit":{"message":"[Discover][Unified
Tabs] Rename \"Tabs bar menu\" to \"Tabs menu\"
(#243332)","sha":"c620d1103cc6a1d56e192e6c8b54990327607aab"}}]}]
BACKPORT-->

Co-authored-by: Ania Kowalska <[email protected]>
@kibanamachine kibanamachine added v9.2.2 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Discover Discover Application Feature:DiscoverTabs Tabs feature within Discover release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.2.0 v9.2.2 v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Discover] Rename "Tabs bar menu" to "Tabs menu"

4 participants